Fix LoaderAllocator of DynamicMethodTable #111038
Merged
+67
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Jan 2, 2025
jkotas
reviewed
Jan 2, 2025
jkotas
reviewed
Jan 2, 2025
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There is one `DynamicMethodTable` allocated per `Module` if needed. When its instance is being created, an incorrect `LoaderAllocator` is passed to the `CreateMinimalMethodTable` function. Instead of the `Module`'s `LoaderAllocator`, it passes in the default one. That fires an assert in non-release builds of the runtime and it results in incorrect marking of the `MethodTable` as not collectible in case the `Module`'s LoaderAllocator is collectible. This change fixes it by passing in the `LoaderAllocator` of the module instead. Close dotnet#110987
janvorli
force-pushed
the
fix-dynamic-method-table-loader-allocator
branch
from
b7406ce to
07fda5c
Compare
|
@janvorli Looks like the regression test is breaking test builds with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one
DynamicMethodTableallocated perModuleif needed. When its instance is being created, an incorrectLoaderAllocatoris passed to theCreateMinimalMethodTablefunction. Instead of theModule'sLoaderAllocator, it passes in the default one.That fires an assert in non-release builds of the runtime and it results in incorrect marking of the
MethodTableas not collectible in case theModule's LoaderAllocator is collectible.This change fixes it by passing in the
LoaderAllocatorof the module instead.Close #110987