Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] remove EXPORT_EXCEPTION_HANDLING_HELPERS #111033

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[browser] remove EXPORT_EXCEPTION_HANDLING_HELPERS #111033

wants to merge 1 commit into from

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jan 2, 2025 •
edited
Loading

get rid of un-used getExceptionMessage -> __cxa_demangle -> itanium_demangle

Fixes #110861

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Jan 2, 2025
@pavelsavara pavelsavara added this to the 10.0.0 milestone Jan 2, 2025
@pavelsavara pavelsavara requested a review from kg January 2, 2025 13:36
@pavelsavara pavelsavara self-assigned this Jan 2, 2025
@pavelsavara pavelsavara mentioned this pull request Jan 2, 2025
Open
@kg
Copy link
Member

kg commented Jan 2, 2025

Why are they unused? These were needed to fix an exception handling issue in the jiterpreter before.

@pavelsavara
Copy link
Member Author

Why are they unused? These were needed to fix an exception handling issue in the jiterpreter before.

Our code never references getExceptionMessage. Or do you mean something else ?

This was referenced Jan 2, 2025
Open
Open
Open
Open
Open
@pavelsavara
Copy link
Member Author

Maybe this is about __cpp_exception export which is used in jiterp.

https://github.com/emscripten-core/emscripten/blob/537d805bd9c4af12b65c95a1680df3b5f137754d/tools/link.py#L1822-L1834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kg kg Awaiting requested review from kg

@maraf maraf Awaiting requested review from maraf maraf will be requested when the pull request is marked ready for review maraf is a code owner

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger will be requested when the pull request is marked ready for review akoeplinger is a code owner

@steveisok steveisok Awaiting requested review from steveisok steveisok will be requested when the pull request is marked ready for review steveisok is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas will be requested when the pull request is marked ready for review vitek-karas is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

[browser] itanium_demangle symbols in .wasm file
2 participants
@pavelsavara @kg