Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not substitute return values of constrained calls #111030

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

MichalStrehovsky
Copy link
Member

Fixes #110932.

The constraint would need to be resolved first.

Cc @dotnet/ilc-contrib

Fixes dotnet#110932.

The constraint would need to be resolved first.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MichalStrehovsky MichalStrehovsky merged commit efdd299 into dotnet:main Jan 2, 2025
91 of 94 checks passed
MichalStrehovsky added a commit that referenced this pull request Jan 2, 2025
Fixes #110932.

The constraint would need to be resolved first.
@MichalStrehovsky MichalStrehovsky deleted the fix110932 branch January 2, 2025 21:04
@hez2010
Copy link
Contributor

hez2010 commented Jan 4, 2025

I think this needs to be backported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NativeAOT: Usage of static virtual method from interface gets miscompiled as infinite loop
3 participants