Minimize use of unsafe context

[xtqqczze]

Contributes to #94941.

Follow-up to #110953.

cc: @EgorBo

[MihaZupan]

I'm not a fan of this change, these types are very unsafe-adjacent so I don't see why repeating the keyword 7 times is beneficial.
If this were e.g. class HttpClient that happened to have one unsafe helper method in it, I'd feel differently.

[xtqqczze]

This change brings these files into alignment with Vector128, where an unsafe context is not used on the class.

runtime/src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector128.cs

Line 33 in dc0432b

public static class Vector128

[EgorBo]

I agree with @MihaZupan, but since there is already an inconsistency with V128 I guess it's fine to clean up?

PS: it is really unfortunate that sizeof requires unsafe context in C#

[MihaZupan]

Looking at Vector128, a quick search shows 106 "static unsafe", but almost all of them look like they're unnecessary. Consistency is good, but maybe we should do the opposite and mark that type as unsafe too instead? Or perhaps remove the unneeded uses there.

[EgorBo]

Looking at Vector128, a quick search shows 106 "static unsafe", but almost all of them look like they're unnecessary. Consistency is good, but maybe we should do the opposite and mark that type as unsafe too instead? Or perhaps remove the unneeded uses there.

when I was removing redundant unsafe I didn't scan SIMD APIs so I can imagine there are some redundancies there

[stephentoub]

PS: it is really unfortunate that sizeof requires unsafe context in C#

I agree with this. As we move forward with refining exactly what "unsafe" means and adding to what triggers warnings and viral requirements, we should also look at removing things that are no longer appropriate.

[xtqqczze]

PS: it is really unfortunate that sizeof requires unsafe context in C#

It also produces a compiler warning, which we suppress for the repository:

     Warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type

[jkotas]

The overloads that take ref T should be really marked as unsafe too, even though C# does not require it today.