-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0-staging] Don't wait for finalizers in 'IReferenceTrackerHost::ReleaseDisconnectedReferenceSources' #110558
base: release/9.0-staging
Are you sure you want to change the base?
Conversation
@Sergio0694 Would it be possible to validate the fix by building and testing Windows Store app with NAOT from main?
|
Weird, this overload was added in #110234, this must be using some AotSdk with an old corelib (and likely old runtime too, without your fix). What are your repro steps? If you download the latest .NET 10 SDK, it should already have the ILCompiler with your fix. So all that should be needed is to put it in the PATH, add NuGet.config with the .NET 10 feed, update Store to target .NET 10 and that's it. |
That's exactly what I did 🥲 |
Update: I tested again (this time in Release, last time I was trying to run in Debug + Native AOT), and it works! 🎉 I can no longer repro the hangs (no spinning circle on the mouse cursor, no hangs in event viewer), and I can close and reopen the Store multiple times in rapid succession without getting stuck at the OS splash screen (due to the previous instance being hung)! |
@Sergio0694 Thank you for testing the fix! I have submitted the change into servicing approval process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. we will take for consideration in 9.0.x
Backport of #110551 to release/9.0-staging
/cc @jkotas @Sergio0694
Customer Impact
Intermittent hang when UWP/WinUI app is suspended. Reported by Windows Store.
Regression
This is .NET Native -> .NET 9 regression on UWP. The fix updates IReferenceTrackerHost::ReleaseDisconnectedReferenceSources implementation in .NET 9 to match .NET Native (ie reverts the offending change).
Testing
Fix validated on private build by Windows Store
Risk
Low