-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] itanium_demangle symbols in .wasm file #110861
Comments
Tagging subscribers to 'arch-wasm': @lewing |
It also happens on Net9 |
the Itanium demangle is just C++ name mangling on unix systems, used on other architectures than itanium. it is linked away in out publish
|
Adding
|
Interestingly it doesn't happen in intree build in main, but happens in net9 template. I was able to reproduce it locally in net9 and wasmbrowser template. With Pavel we tried to use main's clang and wasm-ld to see if main's linker might behave differently. it still reproduced in net9 template. |
with
|
I'm testing without it here #111033 |
I believe these are still needed for proper exception handling integration. Not specifically the demangle stuff but the other bits that come with the exception handling helpers. It's possible something has changed and they aren't needed, but you would need to manually test to verify that the relevant configurations haven't regressed, as they aren't tested by CI. I don't remember how to test it anymore, to be honest. |
Our .wasm files contain
itanium_demangle
symbols which isLLVMDemangle.lib
from x64See
runtime/src/mono/CMakeLists.txt
Line 606 in 5e38bb1
runtime/src/mono/mono/mini/CMakeLists.txt
Line 386 in 5e38bb1
The text was updated successfully, but these errors were encountered: