Run all cohosting tests with FUSE on and off #11330
Open
+1,233
−1,114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would have been done when we had the source generator branch anyway, and hard coding is a problem now that sometimes we need runtime code-gen
Fixes various "Add Using" tests in FUSE
alexgav
approved these changes
Dec 26, 2024
|
|
||
| public override Task<RunSummary> RunAsync(IMessageSink diagnosticMessageSink, IMessageBus messageBus, object[] constructorArguments, ExceptionAggregator aggregator, CancellationTokenSource cancellationTokenSource) | ||
| { | ||
| Debug.Assert(constructorArguments.Length >= 1 && constructorArguments[0] is FuseTestContext, $"{TestMethod.TestClass.Class.Name}.{TestMethod.Method.Name} uses a formatting test attribute in a class without a FuseTestContext parameter?"); |
There was a problem hiding this comment.
How do we know that a formatting test attribute is getting used?
There was a problem hiding this comment.
Strictly speaking, we don't, but instances of this test case are only created by the discoverer for those attributes. If we could actually know for sure, then this assert wouldn't be needed.
src/Shared/Microsoft.AspNetCore.Razor.Test.Common/Microsoft.AspNetCore.Razor.Test.Common.csproj
Outdated
Show resolved
Hide resolved
alexgav
approved these changes
Dec 27, 2024
|
@dotnet/razor-compiler for 2nd review, in case anyone is back from holidays :) |
I was a bit early with this, but hopefully you're back now @333fred and/or @chsienki ? You only need to look at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/orgs/dotnet/projects/197/views/8?query=is%3Aopen+sort%3Aupdated-desc&pane=issue&itemId=85450324
Review commit and a time is recommended. The second last commit is the only one you need to worry about @dotnet/razor-compiler, it fixes various scenarios around using directives, as previously the code-gen was:
but having any
#line hiddenin a using directive means Roslyn won't offer to add them, so this just updates the code-gen to move the semi-colon to: