Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverting previous commit (34129) to unblock the build #35397

Closed
wants to merge 1 commit into from

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Jan 2, 2025

more tests started failing with to many service provider instances created. Will investigate deeper and reenable in the future

…tarted failing with to many service provider instances created
@maumar maumar requested a review from a team January 2, 2025 09:29
@maumar maumar enabled auto-merge (squash) January 2, 2025 09:30
@SamMonoRT
Copy link
Member

cc @ranma42

@ranma42
Copy link
Contributor

ranma42 commented Jan 2, 2025

will look into it asap

@ranma42
Copy link
Contributor

ranma42 commented Jan 2, 2025

~~locally (in my dev env) f0663b2 passes the testsuite; not sure if this is good or bad news 😅 ~~

Weird/fun fact: if I am reading https://dev.azure.com/dnceng-public/public/_build/results?buildId=904939&view=ms.vss-test-web.build-test-results-tab correctly, Resolve_scoped_application_service passes in CI, while a bunch of Microsoft.EntityFrameworkCore.DbContextLoggerTests tests fail... as if enabling this test caused different side-effects in CI vs locally 🤔

note that the timeout might actually be unrelated to this change: it seem to happen consistently since https://dev.azure.com/dnceng-public/public/_build/results?buildId=904863&view=results

EDIT: can now reproduce locally 🚀

@ranma42
Copy link
Contributor

ranma42 commented Jan 2, 2025

I believe the 3 hours timeout is unrelated to either changeset and instead caused by

  Sending Job to OSX.1200.ARM64.Open...
SENDHELIXJOB : warning : Helix queue osx.1200.arm64.open was set for estimated removal date of 2025-01-01. In most cases the queue will be removed permanently due to end-of-life; please contact dnceng for any questions or concerns, and we can help you decide how to proceed and discuss other options. [D:\a\_work\1\s\eng\helix.proj]
  Sent Helix Job; see work items at https://helix.dot.net/api/jobs/658793f0-96cd-4802-b249-57ba257a2d12/workitems?api-version=2019-06-17

It looks like all of the work items are still waiting and I believe unlikely to ever complete.

OTOH osx.1200.amd64.open gives a similar warning:

  Sending Job to OSX.1200.Amd64.Open...
SENDHELIXJOB : warning : Helix queue osx.1200.amd64.open was set for estimated removal date of 2025-01-01. In most cases the queue will be removed permanently due to end-of-life; please contact dnceng for any questions or concerns, and we can help you decide how to proceed and discuss other options. [D:\a\_work\1\s\eng\helix.proj]
  Sent Helix Job; see work items at https://helix.dot.net/api/jobs/b4b1a7b2-1d3f-4270-b411-b5b3b80fdc21/workitems?api-version=2019-06-17

but apparently finishes its work items 😅

Sorry for the off-topic: this is just to warn that the Helix timeout and the test regressions are probably independent (maybe even completely unrelated).

@AndriySvyryd
Copy link
Member

#35402 should fix the tests.
I'll look into the Helix timeouts later today

@maumar maumar closed this Jan 3, 2025
auto-merge was automatically disabled January 3, 2025 00:28

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants