More translation test work (basic operators, string case sensitivity...) #35373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
roji
commented
Dec 22, 2024
roji
commented
- Case sensitivity/insensitivity ins string translation tests
- Add basic operator translation tests, split operators into separate suites
- Various other tweaks and cleanup
roji
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 28 out of 43 changed files in this pull request and generated no comments.
Files not reviewed (15)
- eng/Versions.props: Language not supported
- test/EFCore.Specification.Tests/Query/GearsOfWarQueryTestBase.cs: Evaluated as low risk
- test/EFCore.SqlServer.FunctionalTests/Query/NorthwindWhereQuerySqlServerTest.cs: Evaluated as low risk
- test/EFCore.SqlServer.FunctionalTests/Query/GearsOfWarQuerySqlServerTest.cs: Evaluated as low risk
- test/EFCore.Cosmos.FunctionalTests/Query/Translations/Operators/ComparisonOperatorTranslationsTest.cs: Evaluated as low risk
- test/EFCore.Cosmos.FunctionalTests/Query/Translations/Operators/LogicalOperatorTranslationsCosmosTest.cs: Evaluated as low risk
- test/EFCore.Cosmos.FunctionalTests/Query/Translations/Operators/MiscellaneousOperatorTranslationsCosmosTest.cs: Evaluated as low risk
- test/EFCore.Cosmos.FunctionalTests/Query/Translations/StringTranslationsCosmosTest.cs: Evaluated as low risk
- test/EFCore.InMemory.FunctionalTests/Query/Translations/BitwiseOperatorTranslationsInMemoryTest.cs: Evaluated as low risk
- test/EFCore.Cosmos.FunctionalTests/Query/Translations/Operators/BitwiseOperatorTranslationsCosmosTest.cs: Evaluated as low risk
- test/EFCore.Cosmos.FunctionalTests/Query/Translations/Operators/ArithmeticOperatorTranslationsCosmosTest.cs: Evaluated as low risk
- test/EFCore.Specification.Tests/Query/NorthwindWhereQueryTestBase.cs: Evaluated as low risk
- test/EFCore.Cosmos.FunctionalTests/Query/Translations/MiscellaneousTranslationsCosmosTest.cs: Evaluated as low risk
- test/EFCore.Specification.Tests/Query/Translations/Operators/BitwiseOperatorTranslationsTestBase.cs: Evaluated as low risk
- test/EFCore.Specification.Tests/Query/Translations/StringTranslationsTestBase.cs: Evaluated as low risk
AndriySvyryd
approved these changes
Jan 3, 2025
roji
force-pushed
the
MoreTranslationTests
branch
from
79bcbf6 to
c17f50d
Compare
* Case sensitivity/insensitivity ins string translation tests * Add basic operator translation tests, split operators into separate suites * Various other tweaks and cleanup
roji
force-pushed
the
MoreTranslationTests
branch
from
c17f50d to
e45d693
Compare
|
Helix-only test failures are unrelated (occur also in main), merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.