Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMALL] Split TemporalTranslations into per-type suites #35371

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

roji
Copy link
Member

@roji roji commented Dec 22, 2024

This is a simple refactor-only change that splits TemporalTranslations into different test suites.

There seem to be enough tests for each type (DateTime, DateTimeOffset...) to justify different suites... But more importantly, for some providers there are multiple mapping options: DateTime can be mapped to timestamp with time zone or timestamp without time zone on PostgreSQL, datetime or datetime2 on SQL Server, etc. This allows easily extending DateTimeTranslationsTestBase twice, once with each mapping strategy.

Continues #34872

@roji roji requested a review from a team December 22, 2024 09:25
@roji roji changed the title Split TemporalTranslations into per-type suites [SMALL] Split TemporalTranslations into per-type suites Dec 22, 2024
@roji
Copy link
Member Author

roji commented Dec 24, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@roji
Copy link
Member Author

roji commented Jan 10, 2025

@dotnet/efteam ping, this is probably the last translation test work PR for now.

@cincuranet
Copy link
Contributor

LGTM in general. Assuming the The type or namespace name 'TemporalTranslationsTestBase<>' could not be found (are you missing a using directive or an assembly reference?) will get fixed.

@roji roji force-pushed the TemporalTranslations branch from f81edbb to 42bd957 Compare January 10, 2025 14:29
@roji roji enabled auto-merge (squash) January 10, 2025 14:29
@roji roji disabled auto-merge January 10, 2025 16:10
@roji roji merged commit 3aa7ec4 into dotnet:main Jan 10, 2025
5 of 7 checks passed
@roji roji deleted the TemporalTranslations branch January 10, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants