Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issues related to .NET containers #44170

Merged
merged 14 commits into from
Jan 7, 2025
Merged

Address issues related to .NET containers #44170

merged 14 commits into from
Jan 7, 2025

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Jan 7, 2025 •
edited by github-actions bot
Loading

Summary

Address issues related to .NET containers:

Localization and translation related issues:

Internal previews

📄 File 🔗 Preview link
docs/core/compatibility/containers/8.0/aspnet-port.md Default ASP.NET Core port changed from 80 to 8080
docs/core/containers/overview.md .NET SDK container creation overview
docs/core/containers/publish-configuration.md Containerize a .NET app reference
docs/core/containers/sdk-publish.md Containerize a .NET app with dotnet publish
docs/core/docker/build-container.md Tutorial: Containerize a .NET app
docs/core/docker/introduction.md docs/core/docker/introduction
docs/core/tools/dotnet-publish.md dotnet publish
docs/core/whats-new/dotnet-7.md What's new in .NET 7
docs/core/whats-new/dotnet-8/containers.md What's new in containers for .NET 8
docs/navigate/devops-testing/toc.yml docs/navigate/devops-testing/toc

@dotnetrepoman dotnetrepoman bot added this to the January 2025 milestone Jan 7, 2025
@IEvangelist IEvangelist marked this pull request as ready for review January 7, 2025 17:03
@IEvangelist IEvangelist requested a review from a team as a code owner January 7, 2025 17:03
@IEvangelist IEvangelist marked this pull request as draft January 7, 2025 17:03
@IEvangelist IEvangelist marked this pull request as ready for review January 7, 2025 17:25
@dotnet-policy-service dotnet-policy-service bot added the okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. label Jan 7, 2025
baronfel
baronfel approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits about the usage of the CLI in the Dockerfile examples, but other than that this is a great refresh!

docs/core/docker/snippets/8.0/App/Dockerfile Outdated Show resolved Hide resolved
docs/core/docker/snippets/9.0/App/Dockerfile Outdated Show resolved Hide resolved
docs/core/docker/publish-as-container.md Outdated Show resolved Hide resolved
baronfel
baronfel approved these changes Jan 7, 2025
View reviewed changes
docs/core/containers/overview.md Outdated Show resolved Hide resolved
docs/navigate/devops-testing/toc.yml Outdated Show resolved Hide resolved
@IEvangelist IEvangelist merged commit 7966015 into dotnet:main Jan 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel approved these changes

@CamSoper CamSoper Awaiting requested review from CamSoper CamSoper is a code owner

@tdykstra tdykstra Awaiting requested review from tdykstra tdykstra is a code owner

@gewarren gewarren Awaiting requested review from gewarren gewarren is a code owner

Assignees
No one assigned
Labels
dotnet-cli/subsvc dotnet-docker/subsvc dotnet-fundamentals/svc okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
Milestone
January 2025
2 participants
@IEvangelist @baronfel