Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the need for sending data after opening a QUIC stream #42324

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Document the need for sending data after opening a QUIC stream #42324

merged 2 commits into from
Sep 2, 2024

Conversation

melbasiouny
Copy link

@melbasiouny melbasiouny commented Aug 25, 2024 •
edited by github-actions bot
Loading

Summary

  • Explain the need for sending data after opening a QUIC stream.
  • Clarify comments, improve code samples, and fix typos.

Internal previews

📄 File 🔗 Preview link
docs/fundamentals/networking/quic/quic-overview.md docs/fundamentals/networking/quic/quic-overview

@melbasiouny melbasiouny requested a review from a team as a code owner August 25, 2024 18:44
@dotnet-bot dotnet-bot added this to the August 2024 milestone Aug 25, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Aug 25, 2024
@melbasiouny melbasiouny mentioned this pull request Aug 25, 2024
Closed
@melbasiouny
Copy link
Author

@dotnet-policy-service agree

liveans
liveans reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@liveans liveans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good.

docs/fundamentals/networking/quic/quic-overview.md Outdated Show resolved Hide resolved
docs/fundamentals/networking/quic/quic-overview.md Outdated Show resolved Hide resolved
docs/fundamentals/networking/quic/quic-overview.md Outdated Show resolved Hide resolved
docs/fundamentals/networking/quic/quic-overview.md Outdated Show resolved Hide resolved
docs/fundamentals/networking/quic/quic-overview.md Outdated Show resolved Hide resolved
docs/fundamentals/networking/quic/quic-overview.md Outdated Show resolved Hide resolved
@melbasiouny
Copy link
Author

I have updated the documentation with the suggestions mentioned, let me know what you think.

liveans
liveans approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@liveans liveans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liveans liveans merged commit a471f7d into dotnet:main Sep 2, 2024
8 checks passed
@liveans
Copy link
Member

liveans commented Sep 2, 2024

Thanks for the contribution @melbasiouny!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liveans liveans liveans approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc dotnet-networking/subsvc
Projects
None yet
Milestone
August 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@melbasiouny @liveans @dotnet-bot