Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite domain in releases.json #9724

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Rewrite domain in releases.json #9724

merged 1 commit into from
Feb 21, 2025

Conversation

richlander
Copy link
Member

@richlander richlander commented Feb 7, 2025

Related: #9675

Blocked on: dotnet/vscode-dotnet-runtime#2123

This transformation is the result of a tool.

  • It builds a new URL based on a specific scheme.
  • Scheme: $"https://builds.dotnet.microsoft.com/dotnet/{component}/{version}/{fileName}"
  • It does a HEAD request on each URL.
  • If the request returns a 200 status code, JSON url is rewritten.
  • A small set of files only exist at download.visualstudio.microsoft.com. I don't know why. I don't think it matters.
  • I ran a script (on the updated files) that validates that every url returns 200. That tool errors (stops) if it hits a non-200 case.
  • Script: https://gist.github.com/richlander/22e23e423951e1b07301e2c392b29720
  • Written by ChatGPT (100% AI generated)
  • Tool: https://gist.github.com/richlander/0d5638c53432b677dd9da5e50d5b9025
  • Written with GitHub Copilot Edits (90% of the code was AI generated)

Copy link
Member

@leecow leecow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating legacy releases.json. LGTM

@richlander
Copy link
Member Author

No word on #9745. We can safely merge this PR.

@richlander richlander merged commit 01914ed into main Feb 21, 2025
2 checks passed
@richlander richlander deleted the json-domain-rewrite branch February 21, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants