Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make xcopy-deployable on Windows #138

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make xcopy-deployable on Windows #138

wants to merge 2 commits into from

Conversation

vatsan-madhavan
Copy link
Member

Here is an attempt at addressing #134

/cc @sfoslund

@sfoslund
Copy link
Member

sfoslund commented Apr 6, 2020

Thanks for your contribution! This looks good to me and the official build output is right. @wli3 look okay to you?

@sfoslund sfoslund requested a review from wli3 April 6, 2020 15:39
wli3
wli3 suggested changes Apr 6, 2020
View reviewed changes
Copy link

@wli3 wli3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hold

@vatsan-madhavan
Copy link
Member Author

Thanks for your contribution! This looks good to me and the official build output is right

Should the symbol file be excluded from the zip file ?

Base automatically changed from master to main March 17, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wli3 wli3 wli3 requested changes

@sfoslund sfoslund sfoslund approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vatsan-madhavan @sfoslund @wli3