Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply schema transformer to AdditionalProperties #59699

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Apply schema transformer to AdditionalProperties #59699

merged 1 commit into from
Jan 6, 2025
+15 −2

Conversation

JTeeuwissen
Copy link
Contributor

Apply schema transformer to AdditionalProperties

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Applied InnerApplySchemaTransformersAsync to AdditionalProperties where AdditionalPropertiesAllowed and jsonTypeInfo has an ElementType

Description

Fixed schema generation for AdditionalProperties, the result of a dictionary value type.

Fixes #59616

@JTeeuwissen JTeeuwissen requested review from captainsafia and a team as code owners January 3, 2025 07:06
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-web-frameworks *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels label Jan 3, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 3, 2025
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0.x milestone Jan 3, 2025
@captainsafia
Copy link
Member

@JTeeuwissen Thanks for opening this PR! It looks great overall and is good to merge.

However, it's currently set up to target the release/9.0 branch. Can you update it to retarget to main?

Since .NET 9 is publicly released, changes to it have to go through the servicing process in order to make it in. The servicing process is documented here.

TL;DR: We'll retarget this PR to main and merge. Then we'll open a backport PR to release/9.0 and I'll take it through the servicing process for incorporation into the patch releases.

@captainsafia captainsafia added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-openapi area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc pr: pending author input For automation. Specifically separate from Needs: Author Feedback and removed area-web-frameworks *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels labels Jan 3, 2025
@JTeeuwissen JTeeuwissen changed the base branch from release/9.0 to main January 3, 2025 15:56
@JTeeuwissen JTeeuwissen changed the base branch from main to release/9.0 January 3, 2025 15:56
@JTeeuwissen JTeeuwissen force-pushed the additionalProperties branch from 97e004c to 4f3121e Compare January 3, 2025 16:02
@JTeeuwissen JTeeuwissen changed the base branch from release/9.0 to main January 3, 2025 16:02
@captainsafia captainsafia removed request for a team January 3, 2025 16:06
@mkArtakMSFT mkArtakMSFT added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Jan 3, 2025
@JTeeuwissen
Copy link
Contributor Author

@dotnet-policy-service agree

@captainsafia captainsafia removed this from the 9.0.x milestone Jan 6, 2025
@captainsafia captainsafia removed the pr: pending author input For automation. Specifically separate from Needs: Author Feedback label Jan 6, 2025
captainsafia
captainsafia approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for dealing with the branch change and CLA agreement!

@captainsafia captainsafia merged commit a1f4e1b into dotnet:main Jan 6, 2025
27 checks passed
@captainsafia
Copy link
Member

/backport to release/9.0

@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Jan 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Started backporting to release/9.0: https://github.com/dotnet/aspnetcore/actions/runs/12634564157

@github-actions github-actions bot mentioned this pull request Jan 6, 2025
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

Assignees

@captainsafia captainsafia

Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc community-contribution Indicates that the PR has been added by a community member feature-openapi
Projects
None yet
Milestone
10.0-preview1
Development

Successfully merging this pull request may close these issues.

Values of additionalProperties not transformed
3 participants
@JTeeuwissen @captainsafia @mkArtakMSFT