Suppress CP1002 temporarily via NoWarn

The NoWarn can be removed when dotnet/sdk#46059 got merged and consumed with a new .NET SDK.
dotnet · Jan 16, 2025 · cd5121c · cd5121c
1 parent fc7d7fc
commit cd5121c
Show file tree

Hide file tree

Showing 15 changed files with 16 additions and 75 deletions.
diff --git a/src/Caching/SqlServer/src/Microsoft.Extensions.Caching.SqlServer.csproj b/src/Caching/SqlServer/src/Microsoft.Extensions.Caching.SqlServer.csproj
@@ -6,7 +6,8 @@
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageTags>cache;distributedcache;sqlserver</PackageTags>
     <ExcludeFromSourceOnlyBuild>true</ExcludeFromSourceOnlyBuild>
-    <NoWarn>$(NoWarn);PKG0001</NoWarn>
+    <!-- Temporarily suppress APICompat CP1002 which warns on .NET Framework as it can't find load internal assemblies: SMDiagnostics.dll and System.ServiceModel.Internals.dll -->
+    <NoWarn>$(NoWarn);PKG0001;CP1002</NoWarn>
     <IsPackable>true</IsPackable>
     <IsShipping>true</IsShipping>
   </PropertyGroup>

diff --git a/src/DataProtection/DataProtection/src/CompatibilitySuppressions.xml b/src/DataProtection/DataProtection/src/CompatibilitySuppressions.xml
diff --git a/src/DataProtection/DataProtection/src/Microsoft.AspNetCore.DataProtection.csproj b/src/DataProtection/DataProtection/src/Microsoft.AspNetCore.DataProtection.csproj
@@ -12,6 +12,8 @@
     <Nullable>annotations</Nullable>
     <Nullable Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)'">enable</Nullable>
     <IsTrimmable>true</IsTrimmable>
+    <!-- Temporarily suppress APICompat CP1002 which warns on .NET Framework as it can't find load internal assemblies: SMDiagnostics.dll and System.ServiceModel.Internals.dll -->
+    <NoWarn>$(NoWarn);CP1002</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/DataProtection/Extensions/src/CompatibilitySuppressions.xml b/src/DataProtection/Extensions/src/CompatibilitySuppressions.xml
diff --git a/src/DataProtection/Extensions/src/Microsoft.AspNetCore.DataProtection.Extensions.csproj b/src/DataProtection/Extensions/src/Microsoft.AspNetCore.DataProtection.Extensions.csproj
@@ -8,6 +8,8 @@
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageTags>aspnetcore;dataprotection</PackageTags>
     <IsTrimmable>true</IsTrimmable>
+    <!-- Temporarily suppress APICompat CP1002 which warns on .NET Framework as it can't find load internal assemblies: SMDiagnostics.dll and System.ServiceModel.Internals.dll -->
+    <NoWarn>$(NoWarn);CP1002</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/DataProtection/StackExchangeRedis/src/CompatibilitySuppressions.xml b/src/DataProtection/StackExchangeRedis/src/CompatibilitySuppressions.xml
diff --git a/...tion/StackExchangeRedis/src/Microsoft.AspNetCore.DataProtection.StackExchangeRedis.csproj b/...tion/StackExchangeRedis/src/Microsoft.AspNetCore.DataProtection.StackExchangeRedis.csproj
@@ -7,6 +7,8 @@
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageTags>aspnetcore;dataprotection;redis</PackageTags>
     <IsTrimmable>true</IsTrimmable>
+    <!-- Temporarily suppress APICompat CP1002 which warns on .NET Framework as it can't find load internal assemblies: SMDiagnostics.dll and System.ServiceModel.Internals.dll -->
+    <NoWarn>$(NoWarn);CP1002</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/Features/JsonPatch/src/CompatibilitySuppressions.xml b/src/Features/JsonPatch/src/CompatibilitySuppressions.xml
diff --git a/src/Features/JsonPatch/src/Microsoft.AspNetCore.JsonPatch.csproj b/src/Features/JsonPatch/src/Microsoft.AspNetCore.JsonPatch.csproj
@@ -8,6 +8,8 @@
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <PackageTags>aspnetcore;json;jsonpatch</PackageTags>
     <Nullable>disable</Nullable>
+    <!-- Temporarily suppress APICompat CP1002 which warns on .NET Framework as it can't find load internal assemblies: SMDiagnostics.dll and System.ServiceModel.Internals.dll -->
+    <NoWarn>$(NoWarn);CP1002</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/FileProviders/Embedded/src/CompatibilitySuppressions.xml b/src/FileProviders/Embedded/src/CompatibilitySuppressions.xml
@@ -1,13 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
-  <Suppression>
-    <DiagnosticId>CP1002</DiagnosticId>
-    <Target>SMDiagnostics.dll</Target>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP1002</DiagnosticId>
-    <Target>System.ServiceModel.Internals.dll</Target>
-  </Suppression>
   <Suppression>
     <DiagnosticId>CP1003</DiagnosticId>
     <Target>lib/net7.0/Microsoft.Extensions.FileProviders.Embedded.dll</Target>

diff --git a/src/FileProviders/Embedded/src/Microsoft.Extensions.FileProviders.Embedded.csproj b/src/FileProviders/Embedded/src/Microsoft.Extensions.FileProviders.Embedded.csproj
@@ -13,6 +13,8 @@
     <NoPackageAnalysis>true</NoPackageAnalysis>
     <Nullable>enable</Nullable>
     <IsTrimmable>true</IsTrimmable>
+    <!-- Temporarily suppress APICompat CP1002 which warns on .NET Framework as it can't find load internal assemblies: SMDiagnostics.dll and System.ServiceModel.Internals.dll -->
+    <NoWarn>$(NoWarn);CP1002</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/SignalR/common/Protocols.MessagePack/src/CompatibilitySuppressions.xml b/src/SignalR/common/Protocols.MessagePack/src/CompatibilitySuppressions.xml
diff --git a/...ommon/Protocols.MessagePack/src/Microsoft.AspNetCore.SignalR.Protocols.MessagePack.csproj b/...ommon/Protocols.MessagePack/src/Microsoft.AspNetCore.SignalR.Protocols.MessagePack.csproj
@@ -6,6 +6,8 @@
     <RootNamespace>Microsoft.AspNetCore.SignalR</RootNamespace>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <Nullable>enable</Nullable>
+    <!-- Temporarily suppress APICompat CP1002 which warns on .NET Framework as it can't find load internal assemblies: SMDiagnostics.dll and System.ServiceModel.Internals.dll -->
+    <NoWarn>$(NoWarn);CP1002</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/SignalR/common/Protocols.NewtonsoftJson/src/CompatibilitySuppressions.xml b/src/SignalR/common/Protocols.NewtonsoftJson/src/CompatibilitySuppressions.xml
diff --git a/...Protocols.NewtonsoftJson/src/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson.csproj b/...Protocols.NewtonsoftJson/src/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson.csproj
@@ -6,6 +6,8 @@
     <RootNamespace>Microsoft.AspNetCore.SignalR</RootNamespace>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <Nullable>enable</Nullable>
+    <!-- Temporarily suppress APICompat CP1002 which warns on .NET Framework as it can't find load internal assemblies: SMDiagnostics.dll and System.ServiceModel.Internals.dll -->
+    <NoWarn>$(NoWarn);CP1002</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>