Support building sid and alpine rootfs for loongarch64 #15291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2024
driver1998
reviewed
Dec 6, 2024
This is a step towards eventual access to public CI resources to catch build regressions etc. earlier. As LoongArch support has not reached any public release of Debian, currently only sid is covered, while alpine versions from 3.21 onwards are supported. This is tested on a x86_64 system with qemu-loongarch64 linux-user emulation set up, because the debootstrap second stage needs to run binaries of the target architecture. The following invocations work: * `eng/common/cross/build-rootfs.sh loongarch64 sid --rootfsdir /test` * `eng/common/cross/build-rootfs.sh loongarch64 alpineedge --skipsigcheck --rootfsdir /test` * `eng/common/cross/build-rootfs.sh loongarch64 alpine --skipsigcheck --rootfsdir /test`
xen0n
force-pushed
the
loongarch64-rootfs
branch
from
0d84998 to
f774810
Compare
|
@dotnet-policy-service agree |
xen0n
changed the title
akoeplinger
requested changes
Dec 11, 2024
| @@ -766,7 +799,7 @@ elif [[ -n "$__CodeName" ]]; then | |||
| cat > "$__RootfsDir/etc/apt/sources.list.d/$__CodeName.sources" <<EOF | |||
| Types: deb | |||
| URIs: $__UbuntuRepo | |||
| Suites: $__CodeName $(echo $__UbuntuSuites | xargs -n 1 | xargs -I {} echo -n "$__CodeName-{} ") | |||
| Suites: $__CodeName $__DebianRawSuites $(echo $__UbuntuSuites | xargs -n 1 | xargs -I {} echo -n "$__CodeName-{} ") | |||
There was a problem hiding this comment.
typo:
Suggested change
| Suites: $__CodeName $__DebianRawSuites $(echo $__UbuntuSuites | xargs -n 1 | xargs -I {} echo -n "$__CodeName-{} ") | |
| Suites: $__CodeName $__DebianSuitesRaw $(echo $__UbuntuSuites | xargs -n 1 | xargs -I {} echo -n "$__CodeName-{} ") |
| __UbuntuRepo="http://ftp.debian.org/debian/" | ||
| # Debian-Ports architectures need different values | ||
| case "$__UbuntuArch" in | ||
| amd64|arm64|armel|armhf|i386|mips64el|ppc64el|riscv64|s390x) |
There was a problem hiding this comment.
I think I'd prefer just special casing loong64 here and use * for everything else.
|
/cc @am11 |
am11
suggested changes
Dec 11, 2024
There was a problem hiding this comment.
Duplicate of #8333
We also have a tracking issue dotnet/dotnet-buildtools-prereqs-docker#856. We should wait for debootstrap to support this and not add unreleased stuff in our infrastructure. Meanwhile, you can keep it in your own infra. There is no rush as we are already waiting for it for over two years.
|
@am11 what are we waiting for in debootstrap? |
am11
reviewed
Dec 11, 2024
| if [[ -z "$__UbuntuRepo" ]]; then | ||
| __UbuntuRepo="http://ftp.ports.debian.org/debian-ports/" | ||
| fi | ||
| __UbuntuPackages="${__UbuntuPackages} debian-ports-archive-keyring" |
There was a problem hiding this comment.
We should download the keyring in the host layer with proper checksum https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/a397a76ee5995eba2dc61a4cd1faa60f4235fc52/src/azurelinux/3.0/net10.0/crossdeps-builder/amd64/Dockerfile#L37
Suggested change
| __UbuntuPackages="${__UbuntuPackages} debian-ports-archive-keyring" |
am11
reviewed
Dec 11, 2024
Comment on lines
452
to
+459
| elif [[ "$__AlpineArch" == "riscv64" ]]; then | ||
| __AlpineLlvmLibsLookup=1 | ||
| __AlpineVersion=edge # minimum version with APKINDEX.tar.gz (packages archive) | ||
| elif [[ "$__AlpineArch" == "loongarch64" ]]; then | ||
| __AlpineLlvmLibsLookup=1 | ||
| if [[ "$__AlpineMajorVersion" -lt 3 || "$__AlpineMinorVersion" -lt 21 ]]; then | ||
| __AlpineVersion=3.21 # minimum version with loongarch64 support | ||
| fi |
There was a problem hiding this comment.
I'd merge these two branches and set them to alpine 3.21 and llvm 19:
Suggested change
| elif [[ "$__AlpineArch" == "riscv64" ]]; then | |
| __AlpineLlvmLibsLookup=1 | |
| __AlpineVersion=edge # minimum version with APKINDEX.tar.gz (packages archive) | |
| elif [[ "$__AlpineArch" == "loongarch64" ]]; then | |
| __AlpineLlvmLibsLookup=1 | |
| if [[ "$__AlpineMajorVersion" -lt 3 || "$__AlpineMinorVersion" -lt 21 ]]; then | |
| __AlpineVersion=3.21 # minimum version with loongarch64 support | |
| fi | |
| elif [[ "$__AlpineArch" == "loongarch64" || "$__AlpineArch" == "riscv64" ]]; then | |
| __AlpineVersion=3.21 | |
| __AlpinePackages+=" llvm19-libs" |
|
Superseded by #15370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards eventual access to public CI resources to catch build regressions etc. earlier. As LoongArch support has not reached any public release of Debian or Alpine, currently only sid and alpineedge are covered.
This is tested on a x86_64 system with qemu-loongarch64 linux-user emulation set up, because the debootstrap second stage needs to run binaries of the target architecture. The following invocations work:
eng/common/cross/build-rootfs.sh loongarch64 sid --rootfsdir /testeng/common/cross/build-rootfs.sh loongarch64 alpineedge --skipsigcheck --rootfsdir /testTo double check: