Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use structs for element factory #1844

Draft
wants to merge 1 commit into
base: add-child
Choose a base branch
from

Conversation

twsouthwick
Copy link
Member

@twsouthwick twsouthwick commented Nov 27, 2024

This helps a bit with performance:

Before

Method Mean Error StdDev Gen0 Gen1 Allocated
Create 41.71 us 0.776 us 0.762 us 6.1035 0.2441 51.52 KB
CreateNoSave 40.32 us 0.729 us 0.780 us 6.1035 0.2441 51.52 KB
ReadFile 847.70 us 16.828 us 29.474 us 29.2969 3.9063 255.22 KB

After

Method Mean Error StdDev Gen0 Gen1 Allocated
Create 40.80 us 0.665 us 0.589 us 6.1035 0.2441 51.52 KB
CreateNoSave 40.50 us 0.561 us 0.438 us 6.1035 0.2441 51.52 KB
ReadFile 830.07 us 14.996 us 22.446 us 29.2969 3.9063 255.22 KB

@twsouthwick twsouthwick changed the title Minimize allocations for creating element lookup Use structs for element factory Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant