Remove generic builder pattern from element metadata creation (Part 1) #1842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of what will probably be a few PRs to replace the generic builder pattern in use for defining element metadata. This causes a lot of JITing to occur and causes the ballooning of AOT builds.
Looks like around 5% faster while doing a file read. This has removed about 25% of the generic types, so potentially will make things about 25% faster once completed.
Before
After