Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving things from repoman to policy #34424

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

adegeo
Copy link
Contributor

@adegeo adegeo commented Dec 30, 2024

As we're scaling back RepoMan's usage, I've converted these functions to the .NET Policy Service.

RepoMan migration:

  • Logic related to Not Triaged label
    • Label added when...
      • Issue opened/reopened
      • needs-more-info label is removed (flags issue so we know to respond after we asked for more info)
    • Label removed when...
      • Issue author closes issue
      • reQUEST label added to import the issue into Quest
  • Detect empty issues created via Learn:
    • Close issue
    • Add needs-more-info label
  • Remove mapQUEST label if added (supports project card and Quest integration)

New items

  • Added the missing metadata field in the Learn Issue template.
  • Logic related to needs-more-info label:
    • If the needs-more-info label is on an issue for 14 days, the issue is closed with a message.
    • If a comment is added by the author of the issue, the needs-more-info label is removed.
  • Close issue that has the code-of-conduct label added to it.

Porting github action to policy

  • Port github actions related to adding area lables, I think they were created by @guardrex
    • If label grpc/subsvc added, add label gRPC
    • If label aspnetcore-signalr/subsvc added, add label SignalR
    • Deleted .github/workflows/issue-processing.yml which had this logic.

The blazor issue processing can probably be moved to this too and get rid of the actions.


Internal previews

📄 File 🔗 Preview link
.github/ISSUE_TEMPLATE/customer-feedback.yml .github/ISSUE_TEMPLATE/customer-feedback
.github/policies/close-issues.yml .github/policies/close-issues
.github/policies/issueManagement-emptyIssue.yml .github/policies/issueManagement-emptyIssue
.github/policies/issueManagement-notTriaged.yml .github/policies/issueManagement-notTriaged
.github/policies/labelAdded-areaLabels.yml .github/policies/labelAdded-areaLabels
.github/policies/labelAdded-mapQuest.yml .github/policies/labelAdded-mapQuest
.github/policies/pullRequestManagement-labelFiles.yml .github/policies/pullRequestManagement-labelFiles
.repoman.yml .repoman

@adegeo
Copy link
Contributor Author

adegeo commented Dec 30, 2024

@guardrex
Copy link
Collaborator

Hi @adegeo ... Happy Holidays! ⛄

I just want to make sure that the Blazor issues keep their current processing during the holidays. I'm still recovering from a busy year and don't want to inadvertently lose Blazor issue processing this week while still getting some R&R 🏖️ . I'll look into your suggestion and get back to u next week.

@guardrex
Copy link
Collaborator

guardrex commented Dec 30, 2024

btw @adegeo ... One additional thing that would be helpful to me (and this might not be the right place or time to discuss it) is when a PR is opened on a Blazor article, I should be added as a reviewer. The docs in question are shown in the docfx.json file here ...

https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/docfx.json#L79-L84

When I tried to set up a workflow for a PR, it had a permissions failure. I believe that there's a setting to allow the scripts to run on PRs, but I don't have access to the setting to enable it. That's assuming that workflows would be used at all for that task.

Back to your suggestion ... I can see the reasoning of it, AND look at the somewhat hackish approach that I had to use to get my workflow working ...

https://github.com/dotnet/AspNetCore.Docs/blob/main/.github/workflows/blazor-issue-processing.yml#L8-L13

... and then you can see what the Blazor Hybrid processor is using here ...

https://github.com/dotnet/AspNetCore.Docs/blob/main/.github/workflows/blazor-hybrid-issue-processing.yml#L8

The actions on these show what I need to do to them (e.g., my holiday message that devs get right now).

When I get back next week, I'll get back to you further on this.

@adegeo
Copy link
Contributor Author

adegeo commented Dec 30, 2024

No rush in getting this merged.

I did see your blazor workflows but didn't want to touch them until we touched base on this PR 😀

I think assigning as reviewer for the blazor stuff is doable. I'll look at adding a config to this PR.

@guardrex
Copy link
Collaborator

Thanks! That would be great because it would allow me to respond to PRs super fast 🏃‍♂️.

@guardrex
Copy link
Collaborator

I'm going to unsubscribe from pings until I get back from 🏖️😆.

@adegeo
Copy link
Contributor Author

adegeo commented Dec 31, 2024

LOL sure.. Trying to test why this config is failing 😁

@adegeo
Copy link
Contributor Author

adegeo commented Dec 31, 2024

Well I fixed it. Seems only assignTo is working. I pinged the product group to see what they say about reviewer. According to their docs, it should have worked.

@adegeo
Copy link
Contributor Author

adegeo commented Dec 31, 2024

Figured it out! The sample code where I took it from was wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants