-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving things from repoman to policy #34424
base: main
Are you sure you want to change the base?
Conversation
Hi @adegeo ... Happy Holidays! ⛄ I just want to make sure that the Blazor issues keep their current processing during the holidays. I'm still recovering from a busy year and don't want to inadvertently lose Blazor issue processing this week while still getting some R&R 🏖️ . I'll look into your suggestion and get back to u next week. |
btw @adegeo ... One additional thing that would be helpful to me (and this might not be the right place or time to discuss it) is when a PR is opened on a Blazor article, I should be added as a reviewer. The docs in question are shown in the https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/docfx.json#L79-L84 When I tried to set up a workflow for a PR, it had a permissions failure. I believe that there's a setting to allow the scripts to run on PRs, but I don't have access to the setting to enable it. That's assuming that workflows would be used at all for that task. Back to your suggestion ... I can see the reasoning of it, AND look at the somewhat hackish approach that I had to use to get my workflow working ... ... and then you can see what the Blazor Hybrid processor is using here ... The actions on these show what I need to do to them (e.g., my holiday message that devs get right now). When I get back next week, I'll get back to you further on this. |
No rush in getting this merged. I did see your blazor workflows but didn't want to touch them until we touched base on this PR 😀 I think assigning as reviewer for the blazor stuff is doable. I'll look at adding a config to this PR. |
Thanks! That would be great because it would allow me to respond to PRs super fast 🏃♂️. |
I'm going to unsubscribe from pings until I get back from 🏖️😆. |
LOL sure.. Trying to test why this config is failing 😁 |
Well I fixed it. Seems only |
Figured it out! The sample code where I took it from was wrong. |
As we're scaling back RepoMan's usage, I've converted these functions to the .NET Policy Service.
RepoMan migration:
New items
Porting github action to policy
The blazor issue processing can probably be moved to this too and get rid of the actions.
Internal previews