Fixes from previous edits of keycloak json files #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes some issues from previous Lab 3 PR now that (I think) I get how this file is working. Changes:
orderingswaggeruiclient references before it is introduced in the lab, since this breaks redirect URI on import as there is no environment variable being exported in the app host yetURL updates:
labs/3-Add-Identity/end/Keycloak/data/import/eshop-realm.json: UpdatedrootUrl,adminUrl, andbaseUrlto use HTTPS instead of HTTP.labs/3-Add-Identity/src/Keycloak/data/import/eshop-realm.json: Similar updates to URLs as in the above file.Removal of
orderingswaggeruiclient:labs/4-Add-Shopping-Basket/end/Keycloak/data/import/eshop-realm.json: Removed theorderingswaggeruiclient from the realm configuration. [1] [2]labs/4-Add-Shopping-Basket/src/Keycloak/data/import/eshop-realm.json: Similar removal oforderingswaggeruiclient as in the above file. [1] [2]Secret updates:
labs/4-Add-Shopping-Basket/end/Keycloak/data/import/eshop-realm.json: Replaced hardcoded secret with${WEBAPP_CLIENT_SECRET}environment variable.labs/4-Add-Shopping-Basket/src/Keycloak/data/import/eshop-realm.json: Similar secret update as in the above file.labs/5-Add-Checkout/end/Keycloak/data/import/eshop-realm.json: Similar secret update.labs/5-Add-Checkout/src/Keycloak/data/import/eshop-realm.json: Similar secret update.labs/6-Add-Resiliency/src/Keycloak/data/import/eshop-realm.json: Similar secret update.