Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout member added to ehrclient class #89

Merged
merged 16 commits into from
Oct 25, 2024
Merged

Timeout member added to ehrclient class #89

merged 16 commits into from
Oct 25, 2024

Conversation

Vortex-21
Copy link
Contributor

Description

Timeout member added as requested.

Related Issue

#67

Changes Made

-added timeout as a member in the ehrclient
-passed timeout as config in the related TODO

Testing

Tested against the already existing tests .

Checklist

  • I have read the contributing guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

@Vortex-21
Copy link
Contributor Author

I have made the necessary changes as requested . Hope it works fine!

@jenniferjiangkells jenniferjiangkells self-requested a review October 24, 2024 07:29
jenniferjiangkells
jenniferjiangkells requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@jenniferjiangkells jenniferjiangkells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what we want ⭐ Could you just update the docstring to reflect the new parameter? Thanks!

@Vortex-21
Copy link
Contributor Author

I have updated the docstring !

adamkells
adamkells approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@adamkells adamkells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jenniferjiangkells jenniferjiangkells merged commit ed7c69f into dotimplement:main Oct 25, 2024
5 checks passed
@jenniferjiangkells jenniferjiangkells linked an issue Nov 26, 2024 that may be closed by this pull request
Pass timeout as configuration in EHRClient #67
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenniferjiangkells jenniferjiangkells jenniferjiangkells approved these changes

@adamkells adamkells adamkells approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass timeout as configuration in EHRClient
3 participants
@Vortex-21 @adamkells @jenniferjiangkells