Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the find section by code functionality #87

Merged
merged 11 commits into from
Oct 23, 2024

Conversation

Vortex-21
Copy link
Contributor

Description

I have updated the cdaannotator by adding the _find_section_by_code() function and modifying the related functions such that if the cda document doesn't contain template_ids then it can identify and retrieve the related sections using their respective code values .

Related Issue

#66

Changes Made

-Added SectionCode Enum.
-Added _find_section_by_code() function.
-Updated the related functions like _find_problems_section().
-Added and updated tests for a document which doesn't contain template_ids for various sections .

Testing

I have added tests similar to the already existing tests but with a different instance of the cdaAnnotator which contains data from that xml document which doesnt have any template_ids.

Checklist

  • I have read the contributing guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

@jenniferjiangkells jenniferjiangkells self-requested a review October 19, 2024 17:51
Copy link
Member

@jenniferjiangkells jenniferjiangkells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you so much for your second contribution @Vortex-21! 🌟

@Vortex-21
Copy link
Contributor Author

Looks good to me. Thank you so much for your second contribution @Vortex-21! 🌟

@jenniferjiangkells Thank you so much for your kind words! 😊 I'm really glad I could contribute .

@jenniferjiangkells jenniferjiangkells merged commit 3efcb92 into dotimplement:main Oct 23, 2024
5 checks passed
@jenniferjiangkells jenniferjiangkells linked an issue Nov 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse CDA section by code in addition to templateId
3 participants