Overflow and Type Errors added to concept.py . Required tests for qua…

.python-version

@@ -0,0 +1 @@
+3.10.11

healthchain/models/data/concept.py

@@ -1,5 +1,5 @@
 from enum import Enum
-from pydantic import BaseModel, Field
+from pydantic import BaseModel, Field, field_validator
 from typing import Optional, Dict, Union
 
 
@@ -20,6 +20,22 @@ class Quantity(DataType):
     # TODO: validate conversions str <-> float
     value: Optional[Union[str, float]] = None
     unit: Optional[str] = None
+
+    @field_validator('value')
+    @classmethod
+    def validate_value(cls, value:Union[str,float]): 
+        if value is None:
+            raise TypeError(f"Value CANNOT be a {type(value)} object. Must be float or string in float format.")
+
+        try : 
+            return float(value)
+
+        except ValueError : 
+            raise ValueError(f"Invalid value '{value}' . Must be a float Number.")
+
+        except OverflowError:
+            raise OverflowError(f"Invalid value . Value is too large resulting in overflow.")
+
 
 
 class Range(DataType):

pyproject.toml

@@ -35,6 +35,7 @@ termcolor = "^2.4.0"
 spyne = "^2.14.0"
 lxml = "^5.2.2"
 xmltodict = "^0.13.0"
+pytest = "^8.3.3"
 
 [tool.poetry.group.dev.dependencies]
 ruff = "^0.4.2"

tests/test_quantity_class.py

@@ -0,0 +1,39 @@
+import pytest 
+from healthchain.models.data.concept import Quantity
+from pydantic import ValidationError
+#Valid Cases
+def test_valid_float_and_integer():
+    valid_floats = [1.0, .1, 4., 5.99999, 12455.321, 33, 1234]
+    for num in valid_floats : 
+        q = Quantity(value  = num,unit = "mg");
+        assert q.value == num
+
+def test_valid_string():
+    valid_strings = ["100","100.000001",".1","1.",".123","1234.","123989"]
+    for string in valid_strings:
+        q = Quantity(value = string,unit = "mg");
+        assert q.value == float(string)
+
+# Invalid Cases
+def test_invalid_strings():
+    invalid_strings = ["1.0.0", "1..123", "..123","12..","12a.56","1e4.6","12#.45","12.12@3","12@3"]
+    for string in invalid_strings:
+        with pytest.raises(ValidationError) as exception_info:
+            q = Quantity(value = string,unit = "mg")
+        assert "Invalid value" in str(exception_info.value)
+
+
+#Edge Cases
+def test_edge_cases():
+
+    edge_cases = ["", "None", None]
+    for val in edge_cases:
+        with pytest.raises((ValidationError,TypeError)) as exception_info:
+            q = Quantity(value = val,unit = "mg")
+
+        exception_info_str = str(exception_info.value)
+        assert any(msg in exception_info_str for msg in ["CANNOT", "Invalid value"])
+
+# if __name__ == '__main__':
+#     q = Quantity("12","mg");
+#     print(q);