Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch free text loader from json to csv #37

Merged
merged 18 commits into from
Jun 16, 2024
Merged

Conversation

adamkells
Copy link
Contributor

@adamkells adamkells commented Jun 11, 2024

The existing free text loader is a bit complicated. It requires a json and the very specific format isn't documented anywhere. It'll be a lot simpler if we just have a csv with a particular column that contains the free text we care about.

Addresses #34

@adamkells adamkells self-assigned this Jun 11, 2024
@jenniferjiangkells jenniferjiangkells added the Issue: Feature Request ✨ New feature or improvement to existing feature label Jun 11, 2024
@jenniferjiangkells jenniferjiangkells linked an issue Jun 11, 2024 that may be closed by this pull request
@adamkells adamkells marked this pull request as ready for review June 11, 2024 13:23
@adamkells adamkells merged commit 79a7845 into main Jun 16, 2024
3 checks passed
@adamkells adamkells deleted the switch-data-loader-to-csv branch June 16, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request ✨ New feature or improvement to existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Make data generator load free-text from csv file
3 participants