-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[graphiql] fix types to allow overriding endpoint
option
#3727
Conversation
🦋 Changeset detectedLatest commit: 5f4a468 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Apollo Federation Subgraph Compatibility Results
Learn more: |
💻 Website PreviewThe latest changes are available as preview in: https://99f68e46.graphql-yoga.pages.dev |
✅ Benchmark Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have some tests to confirm the use case is working?
@ardatan It's not that easy to test it. And it was already working, it's more a fix in the types that was nor reflecting the underlying implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some tests. @EmrysMyrddin Could you check then we're good imo.
Perfect ! I was not aware we already had an e2e test with browser setup to test graphiql. That's pretty cool ! |
fixes #gw-117