Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New client-side hooks #83

Merged
merged 6 commits into from
Mar 4, 2024
Merged

New client-side hooks #83

merged 6 commits into from
Mar 4, 2024

Conversation

doseofted
Copy link
Owner

@doseofted doseofted commented Mar 3, 2024

  • Add pre-call and post-call hooks to client (useful for caching)
  • Write tests for new client-side hooks
  • Write tests for existing server-side hooks
  • Update documentation page for configuration
  • Add ability to return result in pre-call hooks (both server and client)
  • Update dependencies of project
  • Add post-call-error and post-request-error hooks. This one needs more thought:
    • Should thrown errors in hook also be thrown on client?
    • Does an error hook make sense or should the error result be thrown to the client, because it's an error?

Copy link

changeset-bot bot commented Mar 3, 2024

🦋 Changeset detected

Latest commit: 14ee571

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@doseofted/prim-rpc Minor
@doseofted/prim-example-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
prim-rpc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 3:58am

…t tests, tested hooks with potential errors in functions
@doseofted doseofted marked this pull request as ready for review March 4, 2024 03:58
@doseofted doseofted merged commit 8c5fb70 into main Mar 4, 2024
3 checks passed
@doseofted doseofted deleted the client-side-hooks branch March 9, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant