Skip to content

Commit

Permalink
revert: remove vault from project (#12)
Browse files Browse the repository at this point in the history
  • Loading branch information
domingo1021 authored Jun 30, 2024
1 parent fd40bb9 commit b679250
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 23 deletions.
16 changes: 7 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,9 @@

### Start with Docker Compose

Docker compose will run multiple containers and start app after dependencies get ready.
Docker compose will run containers and start app after dependencies get ready.

- [x] Redis
- [x] Vault
- [x] Hero-app (NestJS application)

```
Expand Down Expand Up @@ -72,7 +71,7 @@ $ npm run test

```
.
├── config Local config for vault
├── config Local config files
├── logs Logs folder for winston (Node.js logger)
├── scripts Utility scripts (e.g., K6 load test)
├── src Source code
Expand Down Expand Up @@ -107,12 +106,11 @@ $ npm run test
1. `TypeScript` as **programming language**, which is a superset of JS, and also using **Node.js** as runtime.
2. `NestJS` as **backend framework**, and using express as internal library implementation.
3. `Redis` as **Cache**, helps us store data from external API
4. `Vault` as **Secret Manager**, stores Environment variable or Secrets
5. `Docker` as **Container Platform**, helps to containerize application.
6. `Github Actions` as **Continuous Integration** tool, runs test every time PR is created or when code is merged into **main** branch.
7. `ESList` as **JavaScript Linter**
8. `Prettier` as **JavaScript Formatter**
9. `Husky` as **git hooks** to make sure code quality with **pre-commit** and **pre-push** scripts.
4. `Docker` as **Container Platform**, helps to containerize application.
5. `Github Actions` as **Continuous Integration** tool, runs test every time PR is created or when code is merged into **main** branch.
6. `ESList` as **JavaScript Linter**
7. `Prettier` as **JavaScript Formatter**
8. `Husky` as **git hooks** to make sure code quality with **pre-commit** and **pre-push** scripts.

### Library

Expand Down
15 changes: 1 addition & 14 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,4 @@ services:
image: redis:7.2.5-alpine
container_name: hero-cache
ports:
- 6379:6379
vault:
image: vault:1.13.3
container_name: hero-vault
volumes:
- ./config:/vault/config
ports:
- 8200:8200
cap_add:
- IPC_LOCK
environment:
- VAULT_ADDR=http://localhost:8200
- VAULT_TOKEN=myroot
command: server -config=/vault/config
- 6379:6379

0 comments on commit b679250

Please sign in to comment.