Merge branch 'main' of github.com:domingo1021/hero-project

src/cores/types/errorResnpose.ts

@@ -3,6 +3,7 @@ export enum CustomErrorCodes {
   UNAUTHORIZED = 40100,
   FORBIDDEN = 40300,
   NOT_FOUND = 40400,
+  HERO_NOT_FOUND = 40401,
   INTERNAL_SERVER_ERROR = 50000,
   THIRDPARTY_SERVER_ERROR = 50001,
   THIRDPARTY_API_RESPONSE_MISMATCH = 50002,

src/modules/http/http.service.ts

@@ -1,4 +1,4 @@
-import { Injectable, InternalServerErrorException } from '@nestjs/common';
+import { HttpStatus, Injectable, InternalServerErrorException, NotFoundException } from '@nestjs/common';
 import { HttpService } from '@nestjs/axios';
 
 import { AxiosError } from 'axios';
@@ -15,6 +15,7 @@ export class ExternalHttpService {
     GET_HEROES: 'https://hahow-recruit.herokuapp.com/heroes',
     AUTHENTICATE: 'https://hahow-recruit.herokuapp.com/auth',
   };
+
   constructor(private httpService: HttpService) {}
 
   /**
@@ -55,6 +56,12 @@ export class ExternalHttpService {
     return firstValueFrom(
       this.httpService.get(`${this.EXTERNAL_ENDPOINT.GET_HEROES}/${id}`).pipe(
         catchError((error: AxiosError) => {
+          if (error.response?.status === HttpStatus.NOT_FOUND) {
+            throw new NotFoundException({
+              code: CustomErrorCodes.HERO_NOT_FOUND,
+              message: `Hero with id ${id} not found`,
+            });
+          }
           throw new InternalServerErrorException({
             code: CustomErrorCodes.THIRDPARTY_SERVER_ERROR,
             message: error.message,
@@ -84,6 +91,12 @@ export class ExternalHttpService {
     return firstValueFrom(
       this.httpService.get(`${this.EXTERNAL_ENDPOINT.GET_HEROES}/${id}/profile`).pipe(
         catchError((error: AxiosError) => {
+          if (error.status === HttpStatus.NOT_FOUND) {
+            throw new NotFoundException({
+              code: CustomErrorCodes.HERO_NOT_FOUND,
+              message: `Hero with id ${id} not found`,
+            });
+          }
           throw new InternalServerErrorException({
             code: CustomErrorCodes.THIRDPARTY_SERVER_ERROR,
             message: error.message,

test/modules/hero/hero.e2e.spec.ts

@@ -4,6 +4,7 @@ import { CACHE_MANAGER } from '@nestjs/cache-manager';
 
 import * as request from 'supertest';
 import * as nock from 'nock';
+import { AxiosError } from 'axios';
 import { Cache } from 'cache-manager';
 
 import { CustomErrorCodes } from '#cores/types';
@@ -223,6 +224,28 @@ describe('AppController (e2e)', () => {
             expect(res.body.requestId).toMatch(UUID_V4_REGEX);
           });
       });
+
+      it("/heroes/:id, return 404 if hero doesn't exist.", () => {
+        nock(baseUrl)
+          .get(endpoint)
+          .reply(404, {
+            message: 'Hero not found',
+            name: 'Error',
+            config: {},
+            code: '404',
+            request: {},
+            response: { status: 404, statusText: 'Not Found' },
+          } as AxiosError);
+
+        return request(server)
+          .get('/heroes/1')
+          .expect(404)
+          .expect((res) => {
+            expect(res.body.code).toBe(CustomErrorCodes.HERO_NOT_FOUND);
+            expect(res.body.message).toBeDefined();
+            expect(res.body.requestId).toMatch(UUID_V4_REGEX);
+          });
+      });
     });
 
     describe('With Auth', () => {