Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom httpStatusCode in redirect() #324

Closed
wants to merge 45 commits into from
Closed

Custom httpStatusCode in redirect() #324

wants to merge 45 commits into from

Conversation

ThomasTJdev
Copy link
Contributor

This allows the user to specify the redirect type.

Current solution
Currently it only allow for Http303 redirects.

After PR
This PR allows the user to specify the http status code:

redirect("/") # default 303
redirect("/", httpStatusCode = Http301)
redirect("/", httpStatusCode = Http302)
redirect("/", httpStatusCode = Http303)

ire4ever1190 and others added 30 commits December 1, 2022 17:59
@ire4ever1190
Parse IP address to see what domain to use
81a1145
@bung87
add startup callback to settings for httpbeast
d6cd0bc
@bung87
ci
8851d5c
@ThomasTJdev
Fix CI
dd857cc
@torbencarstens
Add common intellij paths to .gitignore
a4111d9
@torbencarstens
Use 1.6.14 in CI instead of pre-1.6.0 git sha
ad46aa4
@torbencarstens
Add 2.0.0 to test matrix
08bec4a
@torbencarstens
Only test nim-in-action-code/Chapter7 for nim versions < 2.0
2fe8aa7
@torbencarstens
Bump actions/checkout and iffy/install-nim
c631652
@torbencarstens
Run 'git submodule update --init' for 'nimble test' to ensure that al…
f05bd2b 
…l test requirements are present

Only do this when nim version < 2.0
@torbencarstens
Add 'nimble refresh' and 'nimble install' for 'nimble test' task befo…
88b2ace 
…re running the tests
@torbencarstens
Remove trailing whitespace
5c9e5d3
@torbencarstens
Add support for duplicate keys in parameters by adding `paramValuesAs…
fef495a 
…Seq`

In contrast to `params` this returns a `Table[string, seq[string]]`.

Closes dom96#247
@torbencarstens
Adapt params to use cgi.decodeData instead of parseUrlQuery
b8374b4 
This is also the same implementation used in `paramValuesAsSeq` (except
for the return type), this way we ensure the same behaviour for the
parsing/decoding steps.
@torbencarstens
Add tests for dom96#247
f916b25
@torbencarstens
Fix argument name to iffy/install-nim
d330fad
@torbencarstens
Auto accept nimble for refresh/install
1cce8cc
@torbencarstens
Run debug actions in CI
944dc39
@torbencarstens
Only debug 2.0.0
149d5bf
@torbencarstens
Remove debug actions
88e4a29
@torbencarstens
Run nim2 with '--mm:refc'
cda4d39
@torbencarstens
Remove nim2 from CI
85b2692 
Currently the server throws a 'SIGSEGV: Illegal storage access. (Attempt
to read from nil?)'
@torbencarstens
Remove debug when
84035bf
@torbencarstens
Revert "Add common intellij paths to .gitignore"
44d5868 
This reverts commit a4111d9.
@ThomasTJdev
Custom http status code in redirect template
946814b
@ThomasTJdev
Update readme
79c809c
@ThomasTJdev
Update nimble for nim v2.0
c6bd588
@ThomasTJdev
Update tests
b12cbbd
@ThomasTJdev
Bump required nim version
d8f0457
@ThomasTJdev
Remove submodules
cf3d359
@ThomasTJdev ThomasTJdev mentioned this pull request Jan 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThomasTJdev @ire4ever1190 @bung87 @torbencarstens