Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-release-notes] go: sqle,doltdb: Make commit hooks take a DoltDB instead of a datas.Database. Move them to sqle. #8820

Merged
merged 4 commits into from
Feb 11, 2025
Merged

[no-release-notes] go: sqle,doltdb: Make commit hooks take a DoltDB instead of a datas.Database. Move them to sqle. #8820

merged 4 commits into from
Feb 11, 2025

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Feb 5, 2025

No description provided.

@reltuk reltuk requested a review from zachmu February 5, 2025 19:59
@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
0cbff2c ok 5937457
version total_tests
0cbff2c 5937457
correctness_percentage
100.0

@reltuk reltuk force-pushed the aaron/doltdb-commit-hooks-sqle branch from 4424772 to c457dfc Compare February 6, 2025 01:50
@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c457dfc ok 5937457
version total_tests
c457dfc 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@reltuk DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c248410 ok 5937457
version total_tests
c248410 5937457
correctness_percentage
100.0

max-hoffman
max-hoffman approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reltuk reltuk merged commit 529e51e into main Feb 11, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-hoffman max-hoffman max-hoffman approved these changes

@zachmu zachmu Awaiting requested review from zachmu

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reltuk @coffeegoddd @max-hoffman