Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace cli printErrf with printf in server startup logging #8806

Merged
merged 2 commits into from
Feb 3, 2025
Merged

replace cli printErrf with printf in server startup logging #8806

merged 2 commits into from
Feb 3, 2025

Conversation

liuliu-dev
Copy link
Contributor

No description provided.

@liuliu-dev liuliu-dev requested review from tbantle22 and zachmu and removed request for tbantle22 February 3, 2025 21:16
@liuliu-dev liuliu-dev changed the title liuliu/replace-cli-printErrf-with-println liuliu/replace cli printErrf with println Feb 3, 2025
@liuliu-dev liuliu-dev changed the title liuliu/replace cli printErrf with println replace cli printErrf with println in server startup logging Feb 3, 2025
@coffeegoddd
Copy link
Contributor

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000
version result total
3cf7df2 ok 5937457
version total_tests
3cf7df2 5937457
correctness_percentage
100.0

@liuliu-dev liuliu-dev changed the title replace cli printErrf with println in server startup logging replace cli printErrf with printf in server startup logging Feb 3, 2025
zachmu
zachmu approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Contributor

@liuliu-dev DOLT

comparing_percentages
100.000000 to 100.000000
version result total
00cacf4 ok 5937457
version total_tests
00cacf4 5937457
correctness_percentage
100.0

@liuliu-dev liuliu-dev merged commit d1e90c4 into main Feb 3, 2025
21 checks passed
@liuliu-dev liuliu-dev deleted the liuliu/replace-cli-printErrf-with-println branch February 3, 2025 22:29
@BrewTestBot BrewTestBot mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuliu-dev @coffeegoddd @zachmu