Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user and password options for sql-server #8800

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jan 30, 2025

The --user and --password options to sql-server (whether specified on the command line or in a configuration file) allow users to specify an ephemeral superuser to use for the life of the sql-server process. This is a convenient way to temporarily create a superuser, but has several edge cases that can cause unexpected behavior.

This change removes the --user and --password options and instead customers should now explicitly create that user using standard SQL statements for managing users, such as:

CREATE USER myUser@'%' IDENTIFIED BY 'myPassw0rd';
GRANT ALL ON *.* TO myUser@'%';

@fulghum fulghum force-pushed the fulghum/rm-sql-server-user branch from 1ac00cb to 85deca0 Compare January 30, 2025 01:26
@fulghum fulghum force-pushed the fulghum/rm-sql-server-user branch from 85deca0 to 1d213cf Compare January 30, 2025 18:01
@dolthub dolthub deleted a comment from coffeegoddd Jan 30, 2025
@fulghum fulghum force-pushed the fulghum/rm-sql-server-user branch 2 times, most recently from 3e2418d to 7278643 Compare January 30, 2025 20:23
@dolthub dolthub deleted a comment from coffeegoddd Jan 30, 2025
@fulghum fulghum force-pushed the fulghum/rm-sql-server-user branch from 7278643 to ae8ed37 Compare January 30, 2025 22:09
@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ae8ed37 ok 5937457
version total_tests
ae8ed37 5937457
correctness_percentage
100.0

@dolthub dolthub deleted a comment from coffeegoddd Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants