Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up fetch when there are many tags which haven't changed #8770

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

macneale4
Copy link
Contributor

A user remarked that dolt pull took 2 hours to pull changes. This was the result of wasting time for every tag which had not changed. This change alters the tag iteration code to defers the loading of metadata until it's actually required. Testing against user takes less that 1min now.

We don't need dates and authors when just determining if we have the tag.
@macneale4 macneale4 requested a review from coffeegoddd January 17, 2025 21:42
Copy link
Contributor

@coffeegoddd coffeegoddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coffeegoddd
Copy link
Contributor

@macneale4 DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c9083e7 ok 5937457
version total_tests
c9083e7 5937457
correctness_percentage
100.0

@macneale4 macneale4 merged commit bfb3811 into main Jan 17, 2025
21 of 22 checks passed
@macneale4 macneale4 deleted the macneale4/fetch-tags branch January 17, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants