Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-release-notes] Engine test framework for Doltgres #8046

Merged
merged 25 commits into from
Jun 21, 2024
Merged

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Jun 21, 2024

This PR introduces two major changes to how enginetests are defined and run in Dolt:

  1. New Harness interface to abstract Dolt-specific setup logic and make the same test logic usable by Doltgres
  2. Pull test methods defined in Dolt into their own exported methods to be consumed by Doltgres, similar to the contract between GMS and Dolt

There will be more changes necessary as we get these working in Doltgres, but this lets us run all the Dolt enginetests on Doltgres.

@zachmu zachmu requested a review from max-hoffman June 21, 2024 18:11
@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8419789 ok 5937457
version total_tests
8419789 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
bfae6a5 ok 5937457
version total_tests
bfae6a5 5937457
correctness_percentage
100.0

Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am assuming this mostly moving interfaces public/abstracting the DoltHarness. If there are novel code/tests I should be inspecting more closely lmk.

@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
85956dc ok 5937457
version total_tests
85956dc 5937457
correctness_percentage
100.0

@zachmu zachmu merged commit fed318d into main Jun 21, 2024
20 of 21 checks passed
@tbantle22 tbantle22 deleted the zachmu/enginetests branch November 21, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants