-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove user
and password
options for sql-server
#8800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
force-pushed
the
fulghum/rm-sql-server-user
branch
from
January 30, 2025 01:26
1ac00cb
to
85deca0
Compare
fulghum
force-pushed
the
fulghum/rm-sql-server-user
branch
from
January 30, 2025 18:01
85deca0
to
1d213cf
Compare
fulghum
force-pushed
the
fulghum/rm-sql-server-user
branch
2 times, most recently
from
January 30, 2025 20:23
3e2418d
to
7278643
Compare
fulghum
force-pushed
the
fulghum/rm-sql-server-user
branch
from
January 30, 2025 22:09
7278643
to
ae8ed37
Compare
fulghum
force-pushed
the
fulghum/rm-sql-server-user
branch
3 times, most recently
from
January 31, 2025 19:40
0946c3a
to
3adf49b
Compare
macneale4
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple comment updates. Feel free to ship without another read
fulghum
force-pushed
the
fulghum/rm-sql-server-user
branch
2 times, most recently
from
February 3, 2025 19:42
72c5fcc
to
06bc291
Compare
fulghum
force-pushed
the
fulghum/rm-sql-server-user
branch
from
February 3, 2025 21:21
06bc291
to
9dd401c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--user
and--password
options to sql-server (whether specified on the command line or in a configuration file) allow users to specify an ephemeral superuser to use for the life of the sql-server process. This is a convenient way to temporarily create a superuser, but has several edge cases that can cause unexpected behavior.This change removes support for the
--user
and--password
options and instead customers should now explicitly create that user using standard SQL statements for managing users, such as:If
user
orpassword
is specified in a config file, the sql-server will still startup, but will log a warning. If--user
or--password
is specified as a CLI argument the sql-server will error out with an error message explaining the change. The reason for the difference in handling is that it may be harder for customers to update config files.