Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of new orphans (#1) #8

Closed
wants to merge 6 commits into from
Closed

Conversation

zilberd
Copy link

@zilberd zilberd commented Jan 9, 2023

  • Added new resources

Snapshots
VM
Alerts
LB
Certificates
Virtual Networks without Subnet

* Added new resources

Snapshots
VM
Alerts
LB
Certificates
Virtual Networks without Subnet
* New resources
    Application Gateway waf policies
    added subnets without NSGs

* added missing spacer between new blocks
* remove double nsgs
* new ASR disks

* asr json
@FakieHeelflip
Copy link

Hi @dolevshor , what about this PR?
And all the other ones? I am thinking about to contribute to this project, but only if it still is alive. :)

@letmetechyou
Copy link

Hey @FakieHeelflip I'd be interested in keeping this alive.

@dolevshor
Copy link
Owner

Hi @FakieHeelflip,
First, this project is definitely alive and you are more than welcome to contribute to it.

About this PR:

  • Thanks @zilberd for amazing contribution + my apologize that it took me a while to add it to the project.
  • 3 of the PR suggestions were already incorporated as part of the workbook:
    • Load Balancers
    • Certificates
    • Virtual Networks (VNETs) without subnets.
  • The other suggestion are not orphaned resources and that's the reason I can't merged this PR.
    • Snapshot
    • VM
    • Alerts

@dolevshor dolevshor closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants