Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Certificates #17

Closed
wants to merge 8 commits into from
Closed

Add Certificates #17

wants to merge 8 commits into from

Conversation

azurekid
Copy link
Contributor

@azurekid azurekid commented Jun 12, 2023

Change(s):

  • Updated Queries/orphan-resources-queries.md
  • Updated Workbook/Orphan Resources.workbook
  • Updates Workbook/Orphan Resources.json

Reason for Change(s):

  • expanded use-cases with expired certificates
  • added empty lines between the headers and code blocks according to the KQL coding standards
  • added type to code blocks to enable syntax highlighting.

Testing Completed:

  • Yes

Validated if the query was working correctly by extending the lookback period to see results of expired certificates that are attached to a web application.

image

image

@azurekid
Copy link
Contributor Author

@dolevshor Hope this will be added to this amazing solution.

azurekid added 3 commits June 12, 2023 23:21
removed test values for 360 days lookback
removed 360 days test values
removed 360 days testing values
@azurekid
Copy link
Contributor Author

@dolevshor friendly reminder. If there is anything I can help with to maintain this project, please let me know.

@dolevshor
Copy link
Owner

@azurekid First, thank you very much for the suggestion.
I am debating whether certificates fall into the category of orphaned resources? I would love to hear your point of view.

@azurekid
Copy link
Contributor Author

Hi @dolevshor, from a security point of view it doesn't really matter. But because these certificates are Azure resources, they should be cleaned up once expired.

From a red teamer point of view, iet could be interesting to see what old names were attached to web applications based on the expired certificates, and abuse this information to create a malicious web app with the same name and a new certificate.

@dolevshor
Copy link
Owner

Hi @azurekid,
It makes sense that they would be classified as orphaned resources.

I will make sure to add your suggestion to v2.0. (I will publish it today).

@azurekid
Copy link
Contributor Author

Hi @azurekid,
It makes sense that they would be classified as orphaned resources.

I will make sure to add your suggestion to v2.0. (I will publish it today).

Thanks man!

Please shout out if I can help reviewing code etc.
Love doing community work 💪

@dolevshor
Copy link
Owner

Hi @azurekid ,

Now the orphaned Certificates is include in the workbook as part of the v2.0 release.
I close the PR.

Thanks again for this contribution!

@dolevshor dolevshor closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants