Fix PKCS #11 constants test #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PKCS dogtagpki#11 constants test failed on Fedora 40 since it uses NSS 3.97 that provides some new PKCS dogtagpki#11 constants. As a workaround the new constants need to be excluded until NSS 3.97 becomes available on all supported platforms. The test has also been modified to reuse the jss-builder image which already has the build dependencies. Resolves: dogtagpki#993
|
fmarco76
approved these changes
Feb 16, 2024
|
@fmarco76 Thanks! IIRC older JDKs used to ship Sun packages which provided these constants. Newer JDKs don't ship those packages anymore, so now we're providing these constants. I'm not sure how these constants are actually used, but we can certainly discuss that, probably with @ladycfu and @jmagne as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PKCS #11 constants test failed on Fedora 40 since it uses NSS 3.97 that provides some new PKCS #11 constants. As a workaround the new constants need to be excluded until NSS 3.97 becomes available on all supported platforms.
The test has also been modified to reuse the
jss-builderimage which already has the build dependencies.Resolves: #993