Update kea_alg_defs to match NSS 3.97 #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kea_alg_defs array in SSLCipher.c has been updated to match the one defined in NSS 3.97. The assertion that compares the size of the array with ssl_kea_size has also been removed. These changes will allow JSS to work with the newer NSS 3.97 on Fedora Rawhide as well as the older NSS versions on other platforms. Resolves: dogtagpki#991
|
|
@fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
kea_alg_defsarray inSSLCipher.chas been updated to match the one defined in NSS 3.97. The assertion that compares the size of the array withssl_kea_sizehas also been removed. These changes will allow JSS to work with the newer NSS 3.97 on Fedora Rawhide as well as the older NSS versions on other platforms.Resolves: #991
Note: With these changes the build now works on Rawhide and most tests pass too. There are some failures, but they don't seem to be related so they need to be investigated separately: