Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headersdb_file: updated reorg to find common ancestor with memcmp #190

Merged

Conversation

edtubbs
Copy link
Collaborator

@edtubbs edtubbs commented Jan 26, 2024

Update to dogecoin_headers_db_connect_hdr using memcmp to find common ancestor between forks and main chain for any depth of reorg and test.

@edtubbs edtubbs force-pushed the 0.1.3-dev-reorg-any-depth branch from c70b3f3 to f5c81d0 Compare January 27, 2024 02:53
test: updated spv_tests for a 4-block reorg
@edtubbs edtubbs force-pushed the 0.1.3-dev-reorg-any-depth branch from f5c81d0 to b92a8ac Compare January 31, 2024 01:47
Copy link
Member

@xanimo xanimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, tested on x86_64-pc-linux-gnu. could also use dogecoin_hash_equal but memcmp works 👍

@xanimo xanimo merged commit 1ce63c2 into dogecoinfoundation:0.1.3-dev Feb 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants