Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headersdb_file: updated dogecoin_headers_db_connect_hdr to reorg #179

Merged

Conversation

edtubbs
Copy link
Collaborator

@edtubbs edtubbs commented Dec 18, 2023

Updates to dogecoin_headers_db_connect_hdr for reorganization, the addition of arithmetic and comparison functions in arith_uint256 from @xanimo, updates to block header functions for chainwork and new tests for validating chainwork and reorganization.

@edtubbs edtubbs force-pushed the 0.1.3-dev-chainwork_reorg branch 12 times, most recently from 0de7b56 to 5432989 Compare December 21, 2023 21:25
@edtubbs edtubbs force-pushed the 0.1.3-dev-chainwork_reorg branch 4 times, most recently from 7baf7c9 to 2645619 Compare December 22, 2023 21:24
Copy link
Member

@xanimo xanimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, this all looks pretty good and is thoroughly tested on x86_64 linux.

@edtubbs edtubbs force-pushed the 0.1.3-dev-chainwork_reorg branch 9 times, most recently from 6b9b1c3 to f311a23 Compare December 30, 2023 04:01
@edtubbs edtubbs force-pushed the 0.1.3-dev-chainwork_reorg branch 2 times, most recently from 7142a18 to 78df377 Compare January 1, 2024 05:52
@edtubbs edtubbs force-pushed the 0.1.3-dev-chainwork_reorg branch 11 times, most recently from 694fa05 to 5a88619 Compare January 7, 2024 03:04
arith_uint256: added negate, arithmetic and comparisons from xanimo
arith_uint256: updated div_arith_uint256 for long division
arith_uint256: updated get_low64 byte order
block: updated dogecoin_block_header for chainwork
block: updated dogecoin_block_header_copy for chainwork and auxpow flag
block: updated dogecoin_block_header_new to initialize chainwork
block: updated dogecoin_block_header_new to initialize auxpow flag
block: removed duplicate check initialization from dogecoin_auxpow_block_new
chainparams: updated pow_limit for regnet to correct limit
headersdb_file: updated dogecoin_headers_db_free check for prev and genesis
pow: added chainwork to check_pow
validation: updated check_pow for chainwork
spv: added fcntl to dogecoin_spv_client_load for non-blocking stdin
spv: added escape characters to dogecoin_net_spv_post_cmd for shutdown
spv: updated dogecoin_net_spv_post_cmd to free reject_msg
spv: removed direct block request from dogecoin_net_spv_post_cmd
spvnode: moved "done" print after dogecoin_spv_client_free
test: updated block_test to check chainwork of genesis
test: added test_reorg to spv_test
test: updated unittester to test_reorg
@edtubbs edtubbs force-pushed the 0.1.3-dev-chainwork_reorg branch from 5a88619 to 423e831 Compare January 17, 2024 04:58
Copy link
Member

@xanimo xanimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK. 👍

Copy link
Contributor

@michilumin michilumin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MacOS x86 Sonoma 14.2.1, All tests pass, just needed a brew update and brew install libunistring. (probably from Xcode essentials reinstall).

@michilumin michilumin merged commit 66b364b into dogecoinfoundation:0.1.3-dev Jan 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants