wallet: free waddrs in dogecoin_wallet_init #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xanimo
force-pushed
the
0.1.3-dev-free_waddrs
branch
4 times, most recently
from
6b39c43 to
e4aec01
Compare
-remove frees on wallet init -move wallet addr initialization within if no match section of dogecoin_p2pkh_address_to_wallet -assign dogecoin_utxo* directly from vector_idx in dogecoin_wallet_scrape_utxos -conditionally set wallet->unspent->elem_free_f to dogeocin_wallet_utxo_free in dogecoin_wallet_check_transaction
xanimo
force-pushed
the
0.1.3-dev-free_waddrs
branch
from
e4aec01 to
dc2539f
Compare
edtubbs
approved these changes
Dec 22, 2023
michilumin
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-this pr removes 4 memleaks detected in
dogecoin_wallet_initwhen passing in watch addresses. since we store thewaddrin thewallet->waddr_vectorwe really just need to dispose of thewaddrobject being passed back during wallet init. this is also whydogecoin_p2pkh_addr_from_hash160was removed since it's unnecessary.