Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Entrypoint Packages #25

Merged

Conversation

kchason
Copy link
Collaborator

@kchason kchason commented Apr 13, 2022

Allows the package to be properly imported by migrating the entrypoint logic into the module itself.

Notes:

  • The _version.py needs to be executed in setup.py since the module isn't in the path of the setup.py. If the directory is just appended with sys.path.append('sqlite_dissect') it creates a circular dependency since the required packages for the module are not yet installed.
  • Bumped the version number from 0.1.0 to 0.1.1
  • Maintained main.py as a naive wrapper for sqlite_dissect.entrypoint:cli() for backwards compatibility and compliance with existing documentation. Documentation for import will be added in a subsequent PR to allow this to resolve the bug identified in v0.1.0

@kchason kchason mentioned this pull request May 3, 2022
@kchason
Copy link
Collaborator Author

kchason commented May 3, 2022

References #18

@kchason kchason mentioned this pull request May 3, 2022
2 tasks
@dc3-tsd
Copy link
Member

dc3-tsd commented May 3, 2022

Reviewed by TD.

@dc3-tsd dc3-tsd merged commit 7739847 into dod-cyber-crime-center:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants