[WIP] Implemented DependentMappingDriver #105
Conversation
fprochazka
changed the title
|
I think anything done to improve the annotation and metadata drivers is useful but without some tests it's a bit risky! |
|
Agreed, I will work on the tests then :) |
|
Great! Feel free to use some of the demo entities for the purposes of test cases as the annotations there cover alot of the bases. |
- added objectManager accessors instead of entityManager accessors - entityManager accessors are marked as deprecated
|
@MrHash I would like to know now what you think about this... should I invest more time and add tests? Or do you need more persuasion about this feature? :) |
|
Well i think this is a lower priority because it doesn't impact the core feature set, although it is useful. I think the most important major task at the moment is #85 because is opens the possibility for different implementations. Basically the client libararies need another level of abstraction out from the unit of work. Would that be of interest? However this might be a fair amount of work... |
|
I would be interested in making work elasticsearch with elastica, when we have that then we can think about other clients. |
|
That would be great also. I will assign the task to you. thanks |
|
@MrHash Sure :) |
|
Hi i see you have been developing more. Is this pull request still active? i have a yaml mapping feature merged into the |
|
I'm sorry, but I don't think I'll have the time to finish this, since I'm not using doctrine search on my projects currently. |
I don't like much how the driver paths has to be configured. I think it would be great, if you could connect the search metadata driver with the orm/odm metadata driver and reuse the
getAllClassNameslist from parentObjectManager.It's just an idea (I haven't yet tried to execute the code), what do you think?