Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psalm 5.24 #356

Merged
merged 1 commit into from
May 5, 2024
Merged

Psalm 5.24 #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"doctrine/common": "^3.0",
"phpunit/phpunit": "^8.5 || ^9.5",
"symfony/cache": "^4.4 || ^5.4 || ^6.0",
"vimeo/psalm": "4.30.0 || 5.3.0"
"vimeo/psalm": "4.30.0 || 5.24.0"
},
"conflict": {
"doctrine/common": "<2.10"
Expand Down
29 changes: 17 additions & 12 deletions psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,24 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="5.3.0@b6faa3e96b8eb50ec71384c53799b8a107236bb6">
<file src="src/Persistence/AbstractManagerRegistry.php">
<PossiblyNullReference occurrences="1">
<code>getName</code>
</PossiblyNullReference>
<TypeDoesNotContainType occurrences="1">
<code>$parentClass === false</code>
</TypeDoesNotContainType>
<files psalm-version="5.24.0@462c80e31c34e58cc4f750c656be3927e80e550e">
<file src="src/Persistence/Mapping/AbstractClassMetadataFactory.php">
<ArgumentTypeCoercion>
<code><![CDATA[$class]]></code>
</ArgumentTypeCoercion>
</file>
<file src="src/Persistence/Mapping/Driver/SymfonyFileLocator.php">
<PossiblyInvalidOperand>
<code><![CDATA[str_replace($this->nsSeparator, '\\', $fileName)]]></code>
</PossiblyInvalidOperand>
</file>
<file src="src/Persistence/Reflection/EnumReflectionProperty.php">
<InvalidReturnStatement occurrences="1">
<code>$value</code>
<InvalidArgument>
<code><![CDATA[$name]]></code>
</InvalidArgument>
<InvalidReturnStatement>
<code><![CDATA[$value]]></code>
</InvalidReturnStatement>
<PossiblyInvalidArgument occurrences="1">
<code>$value</code>
<PossiblyInvalidArgument>
<code><![CDATA[$value]]></code>
</PossiblyInvalidArgument>
</file>
</files>
1 change: 1 addition & 0 deletions src/Persistence/Reflection/RuntimeReflectionProperty.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ class RuntimeReflectionProperty extends ReflectionProperty
/** @var string */
private $key;

/** @param class-string $class */
public function __construct(string $class, string $name)
{
parent::__construct($class, $name);
Expand Down
4 changes: 2 additions & 2 deletions tests/Persistence/RuntimePublicReflectionPropertyTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function testGetValueOnProxyPublicProperty(): void
$mockProxy->__setInitializer($initializer);

$reflProperty = new RuntimePublicReflectionProperty(
__NAMESPACE__ . '\RuntimePublicReflectionPropertyTestProxyMock',
RuntimePublicReflectionPropertyTestProxyMock::class,
'checkedProperty'
);

Expand All @@ -82,7 +82,7 @@ public function testSetValueOnProxyPublicProperty(): void
$mockProxy->__setInitializer($initializer);

$reflProperty = new RuntimePublicReflectionProperty(
__NAMESPACE__ . '\RuntimePublicReflectionPropertyTestProxyMock',
RuntimePublicReflectionPropertyTestProxyMock::class,
'checkedProperty'
);

Expand Down
Loading