-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identifier type is not set when many2many relations are deleted #8401
Conversation
This looks good, however it also is confusing this wasn't found before. |
This PR also needs tests for this fix. |
b8d5bd6
to
2148662
Compare
Added the unittest and tried to fix the failing checks. |
You're referring to property types, right? You can extend phpcs.xml.dist for those checks that are only supported by PHP 7.4. |
Phpcs is complaining about native return type hint, native property type hint and more that doesn't make sense. Hopefully the unittest covers the change enough so this bugfix can be merged. |
@yoshz we merged a huge PR cleaning up code style into 2.8 yesterday, so there are now conflics. However after merging 2.8.x again you can now run |
060c2db
to
c1f71bf
Compare
I was trying out the new Symfony Ulid doctrine type together with Postgres and found a small bug.
For this use case the Ulid is formatted as UUID so it can be stored using the native GUID type.
In Doctrine this works fine until you want to delete an entity that has many2many relations causing error
SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type uuid
This PR makes sure that the identifier types are set on the delete queries so the Ulid is mapped correctly.