Deprecate Type::addType

doctrine · Jan 16, 2025 · 355887c · 355887c
1 parent 2331fd2
commit 355887c
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 5 deletions.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -8,6 +8,10 @@ awareness about deprecated code.
 
 # Upgrade to 4.3
 
+## Deprecated Type::addType
+
+Use Type::getTypeRegistry()->register() instead.
+
 ## Deprecated `Table::columnsAreIndexed()`
 
 The `Table::columnsAreIndexed()` method has been deprecated.

diff --git a/src/Types/Type.php b/src/Types/Type.php
@@ -138,6 +138,8 @@ public static function lookupName(self $type): string
      * @param class-string<Type> $className The class name of the custom type.
      *
      * @throws Exception
+     *
+     * @deprecated Use Type::getTypeRegistry()->register() instead.
      */
     public static function addType(string $name, string $className): void
     {

diff --git a/tests/Functional/Schema/CustomIntrospectionTest.php b/tests/Functional/Schema/CustomIntrospectionTest.php
@@ -29,7 +29,7 @@ public static function setUpBeforeClass(): void
             self::markTestSkipped('Skip on Oracle');
         }
 
-        Type::addType(MoneyType::NAME, MoneyType::class);
+        Type::getTypeRegistry()->register(MoneyType::NAME, new MoneyType);
     }
 
     public function testCustomColumnIntrospection(): void

diff --git a/tests/Functional/Schema/MySQLSchemaManagerTest.php b/tests/Functional/Schema/MySQLSchemaManagerTest.php
@@ -27,7 +27,7 @@ class MySQLSchemaManagerTest extends SchemaManagerFunctionalTestCase
 {
     public static function setUpBeforeClass(): void
     {
-        Type::addType('point', PointType::class);
+        Type::getTypeRegistry()->register('point', new PointType);
     }
 
     protected function supportsPlatform(AbstractPlatform $platform): bool
@@ -591,7 +591,7 @@ public function testListTableColumnsThrowsDatabaseRequired(): void
 
     public function testSchemaDiffWithCustomColumnTypeWhileDatabaseTypeDiffers(): void
     {
-        Type::addType('custom_type', CustomType::class);
+        Type::getTypeRegistry()->register('custom_type', new CustomType);
 
         $metadataTable = new Table('table_with_custom_type');
         $metadataTable->addColumn('col1', 'custom_type');

diff --git a/tests/Functional/Schema/PostgreSQLSchemaManagerTest.php b/tests/Functional/Schema/PostgreSQLSchemaManagerTest.php
@@ -53,7 +53,7 @@ public function testSupportDomainTypeFallback(): void
         $table = $this->connection->createSchemaManager()->introspectTable('domain_type_test');
         self::assertInstanceOf(DecimalType::class, $table->getColumn('value')->getType());
 
-        Type::addType('MyMoney', MoneyType::class);
+        Type::getTypeRegistry()->register('MyMoney', new MoneyType);
         $this->connection->getDatabasePlatform()->registerDoctrineTypeMapping('MyMoney', 'MyMoney');
 
         $table = $this->connection->createSchemaManager()->introspectTable('domain_type_test');

diff --git a/tests/Platforms/AbstractPlatformTestCase.php b/tests/Platforms/AbstractPlatformTestCase.php
@@ -117,7 +117,7 @@ public function getSQLDeclaration(array $column, AbstractPlatform $platform): st
         if (Type::hasType($type->getName())) {
             Type::overrideType($type->getName(), $type::class);
         } else {
-            Type::addType($type->getName(), $type::class);
+            Type::getTypeRegistry()->register($type->getName(), new $type);
         }
 
         self::assertSame($type->getName(), $this->platform->getDoctrineTypeMapping('TeStTyPe'));