phpstan: lvl 2 -> 3 #1855
Merged
phpstan: lvl 2 -> 3 #1855
+22
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
approved these changes
Jan 14, 2025
dmaicher
approved these changes
Jan 15, 2025
stof
reviewed
Jan 15, 2025
| @@ -59,6 +61,8 @@ protected function getEntityManager($name, $shardId = null) | |||
| throw new InvalidArgumentException('Shards are not supported anymore using doctrine/dbal >= 3'); | |||
| } | |||
|
|
|||
| assert($manager instanceof EntityManager); | |||
There was a problem hiding this comment.
I think this assertion will cause issue for projects decorating the EntityManager. We should probably use EntityManagerInterface as type instead.
There was a problem hiding this comment.
Thanks for feedback. Addressed in 2363c43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.