Use a modern directory structure

[greg0ire]

The recommended directory structure is more similar to what we do in non-bundle repositories.
Also, this means smaller configuration for tools such as PHPCSStandards, PHPUnit or Psalm.

Although this is no bugfix, I'm targeting 2.11.x so that merging up does not become a nightmare.

[greg0ire]

The Psalm failures demonstrate another reason why this is better: the Middleware directory was forgotten in this list:

DoctrineBundle/psalm.xml.dist

Lines 23 to 33 in 7150c1d

	<directory name="CacheWarmer"/>
	<directory name="Command"/>
	<directory name="Controller"/>
	<directory name="DataCollector"/>
	<directory name="Dbal"/>
	<directory name="DependencyInjection"/>
	<directory name="EventSubscriber"/>
	<directory name="Mapping"/>
	<directory name="Repository"/>
	<directory name="Tests"/>
	<directory name="Twig"/>

[ostrolucky]

yes, this is welcome

[greg0ire]

I'm unsure where the 2 svg files should go. Should they go into public, or should I keep them under templates/Collector? They are referenced in

DoctrineBundle/Resources/views/Collector/db.html.twig

Lines 11 to 15 in 7150c1d

	{% if profiler_markup_version >= 3 %}
	{{ include('@Doctrine/Collector/database.svg') }}
	{% else %}
	<span class="icon">{{ include('@Doctrine/Collector/icon.svg') }}</span>
	{% endif %}

[ostrolucky]

Keep them in templates. And let's target next minor.

[greg0ire]

Will address the conflicts once #1768 is merged and merged up.

[stof]

To support the modern structure, the DoctrineBundle class needs to be updated to override the getPath() method (or to extend AsbtractBundle which already does the override) as the bundle class is not at the root path of the bundle anymore.

[stof]

As this seems to be about autoloading the Fixtures namespace, I would suggest using Fixtures\\ as the PSR-4 prefix (and going one level deeper for the path) instead of a fallback for any class.

[greg0ire]

👍 will do in a separate PR

[greg0ire]

To support the modern structure, the DoctrineBundle class needs to be updated to override the getPath() method (or to extend AsbtractBundle which already does the override) as the bundle class is not at the root path of the bundle anymore.

@ostrolucky why did you merge? Is that not an issue?

[greg0ire]

Addressed in #1770